Track build file changes #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
force-pushed
the
track-build-file-changes
branch
from
019c186 to
0402ac4
Compare
This change makes the server register for document lifecycle events like didChange for build files. Previous behavior was to register for file system change events for build files, but eventually we want to give diagnostics, completions, etc. for build files as you type, so we need to track all changes. This change keeps existing behavior from the user's perspective, as we still only reload projects on save, so it serves mostly as a refactor. I also extracted the state managed by SmithyLanguageServer to its own class, ServerState, and flattened ProjectManager into that class, so we can manage the state of the server in a more centralized location.
milesziemer
force-pushed
the
track-build-file-changes
branch
from
0402ac4 to
9f1e92b
Compare
milesziemer
requested review from
kstich and
hpmellema
and removed request for
kstich
hpmellema
reviewed
Oct 28, 2024
src/main/java/software/amazon/smithy/lsp/project/ProjectConfig.java
Outdated
Show resolved
Hide resolved
| for (Project project : attachedProjects.values()) { | ||
| ProjectFile projectFile = project.getProjectFile(path); | ||
| if (projectFile != null) { | ||
| detachedProjects.remove(uri); |
There was a problem hiding this comment.
Im a little confused why we remove it from detached projects here? I would have thought that would get checked correctly in the isDetached below?
There was a problem hiding this comment.
Yea it does, but I'm not calling that method here. I think I meant to end up removing isDetached, but it ended up being too useful. I did some refactoring and pulled the removal logic into the new findAttachedAndRemoveDetached
hpmellema
approved these changes
Nov 5, 2024
yasmewad
pushed a commit
to yasmewad/smithy-language-server
that referenced
this pull request
Nov 5, 2024
This change makes the server register for document lifecycle events like didChange for build files. Previous behavior was to register for file system change events for build files, but eventually we want to give diagnostics, completions, etc. for build files as you type, so we need to track all changes. This change keeps existing behavior from the user's perspective, as we still only reload projects on save, so it serves mostly as a refactor. I also extracted the state managed by SmithyLanguageServer to its own class, ServerState, and flattened ProjectManager into that class, so we can manage the state of the server in a more centralized location.
milesziemer
added a commit
to milesziemer/smithy-language-server
that referenced
this pull request
Nov 6, 2024
Fixes a bug in smithy-lang#168 where the server would send the wrong registration for didSave on Smithy files.
milesziemer
added a commit
that referenced
this pull request
Nov 6, 2024
Fixes a bug in #168 where the server would send the wrong registration for didSave on Smithy files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the server register for document lifecycle events like
didChange for build files. Previous behavior was to register for file
system change events for build files, but eventually we want to give
diagnostics, completions, etc. for build files as you type, so we need
to track all changes. This change keeps existing behavior from the
user's perspective, as we still only reload projects on save, so it
serves mostly as a refactor.
I also extracted the state managed by SmithyLanguageServer to its own
class, ServerState, and flattened ProjectManager into that class, so we
can manage the state of the server in a more centralized location.
Depends on #167
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.